Maor Lipchuk has posted comments on this change. Change subject: core: Validate Storage Domain for Importing Template from confuguration ......................................................................
Patch Set 1: (2 comments) Will be adding also tests fixup http://gerrit.ovirt.org/#/c/32814/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: Validate Storage Domain for Importing Template from confuguration Line 8: Line 9: For each disk in the template, we should fetch the Storage Domain and Line 10: validate if it's exists and active. > s/if it's exists and active/that it exists and is active/ changed to "that it exists and active" Line 11: Line 12: Today, we set the storage id for each image and then use getStorageDomain method to fetch Line 13: the Storage Domain with that id, but once the Storage Domain being initialized, it will always check Line 14: the first Storage Domain every time. Line 9: For each disk in the template, we should fetch the Storage Domain and Line 10: validate if it's exists and active. Line 11: Line 12: Today, we set the storage id for each image and then use getStorageDomain method to fetch Line 13: the Storage Domain with that id, but once the Storage Domain being initialized, it will always check > s/once/when/ done Line 14: the first Storage Domain every time. Line 15: Line 16: Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Line 17: Bug-Url: https://bugzilla.redhat.com/1138200 -- To view, visit http://gerrit.ovirt.org/32814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
