Maor Lipchuk has posted comments on this change. Change subject: core: Validate Storage Domain for Importing Template from confuguration ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32814/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java: Line 66: Line 67: @Before Line 68: public void setUp() throws IOException { Line 69: vmId = Guid.newGuid(); Line 70: storageDomainId = Guid.createGuidFromString("7e2a7eac-3b76-4d45-a7dd-caae8fe0f588"); > Why? This literal isn't reused anywhere... no, it is GUID which is part of the OVF file used only for this Test Line 71: storagePoolId = Guid.newGuid(); Line 72: clusterId = Guid.newGuid(); Line 73: Line 74: // init the injector with the osRepository instance -- To view, visit http://gerrit.ovirt.org/32814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
