Maor Lipchuk has posted comments on this change. Change subject: core: Use the latest OVF_STORE files ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32747/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 251: return ovfEntitiesFromTar; Line 252: } Line 253: Line 254: private void addOvfStoreDiskToDomain(DiskImage ovfDisk) { Line 255: if (ovfDisk != null) { > How can it ever be null? It is a left over from previous changes Line 256: // Setting OVF_STORE disk to be outdated so it will be updated. Line 257: StorageDomainOvfInfo storageDomainOvfInfo = Line 258: new StorageDomainOvfInfo(getStorageDomainId(), Line 259: null, -- To view, visit http://gerrit.ovirt.org/32747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
