Juan Hernandez has posted comments on this change. Change subject: aaa: search by user and groups name when added via rest-api ......................................................................
Patch Set 5: I don't we know why we care, but I know that we used to care, and stopping to care changes the contract of the operation in a backwards incompatible way. Lets say that we have directory entry like this: uid: user25 givenname: Joe The the caller sends the following request: PUT /api/users <user> <name>Joe</name> <domain> <name>whatever</domain> </domain> </user> Before this patch this request worked, and added Joe as a user. After the patch it won't work, thus it breaks backwards compatibility. Same for the other LDAP attributes that aren't matched. -- To view, visit http://gerrit.ovirt.org/31709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c5d7647d8dff5c9f2f67e42e094e883ac2164b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches