Juan Hernandez has posted comments on this change. Change subject: aaa: search by user and groups name when added via rest-api ......................................................................
Patch Set 5: (2 comments) In theory using the "allnames" key used to have the effect of matching any of the $GIVENNAME, sn, $USER_ACCOUNT_NAME or $PRINCIPAL_NAME attributes of the directory server. Changing to "username" will only match $SAMACCOUNTNAME so if I understand correctly this breaks backwards compatibility. http://gerrit.ovirt.org/#/c/31709/5/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java: Line 204: @Test Line 205: public void testAddGroupWithExplicitDirectoryName() throws Exception { Line 206: setUriInfo(setUpBasicUriExpectations()); Line 207: setUpGetEntityExpectations( Line 208: "ADGROUP@" + DOMAIN + ":: name=" + NAMES[0], What is the meaning of this change in indentation? Line 209: SearchType.DirectoryGroup, Line 210: getDirectoryGroup(0) Line 211: ); Line 212: setUpCreationExpectations( Line 243: @Test Line 244: public void testAddGroupWithImplicitDirectoryName() throws Exception { Line 245: setUriInfo(setUpBasicUriExpectations()); Line 246: setUpGetEntityExpectations( Line 247: "ADGROUP@" + DOMAIN + ":: name=" + NAMES[0], Same. Line 248: SearchType.DirectoryGroup, Line 249: getDirectoryGroup(0) Line 250: ); Line 251: setUpCreationExpectations( -- To view, visit http://gerrit.ovirt.org/31709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c5d7647d8dff5c9f2f67e42e094e883ac2164b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
