Juan Hernandez has posted comments on this change. Change subject: packaging: Run with OpenJDK 7 regardless of what is installed ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/engine-service.py Line 109: javaHomeDir = getSysconfig("JAVA_HOME", "/usr/lib/jvm/java-1.7.0-openjdk.x86_64") It is common to have JAVA_HOME in user environments, not so much in the root environment. We could maybe change this variable to ENGINE_JAVA_HOME, to avoid this. We also have another change prepared to check the version of the Java virtual machine: http://gerrit.ovirt.org/5894. -- To view, visit http://gerrit.ovirt.org/6223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches