Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Run with OpenJDK 7 regardless of what is installed
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/engine-service.py
Line 109:     javaHomeDir = getSysconfig("JAVA_HOME", 
"/usr/lib/jvm/java-1.7.0-openjdk.x86_64")
Hi,

I only think the default should be "java", I understand what you say that it 
won't work.
I thought we put JAVA_HOME in the configuration file...

The reason to have two configuration files is simple... user modifiable 
configuration file is preserved during upgrade, so changes may not be 
integrated after upgrade.

Good to know we have problem with IBM Java...

If we want to solve some local issue, of course this is a solution... my 
question is if we invest a little effort, can we make it easier to port and 
solve both this and[1].

Alon.

[1] http://gerrit.ovirt.org/#/c/5129/

--
To view, visit http://gerrit.ovirt.org/6223
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to