Roy Golan has posted comments on this change.
Change subject: packaging: Run with OpenJDK 7 regardless of what is installed
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/engine-service.py
Line 109: javaHomeDir = getSysconfig("JAVA_HOME",
"/usr/lib/jvm/java-1.7.0-openjdk.x86_64")
which means we can't force using 7 because having JAVA_HOME set it common. but
not against overriding user ENV.
we should print a warning for java version is not recommended or something
similar to make this solution complete.
--
To view, visit http://gerrit.ovirt.org/6223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
