Alon Bar-Lev has posted comments on this change. Change subject: kdump: Try to resolve kdump destination host ......................................................................
Patch Set 3: (1 comment) one last minor note... good to know that... exit exception for example should not be handled in these cases. http://gerrit.ovirt.org/#/c/31760/3/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 118: "Kdump destination '%s' addresses: '%s'", Line 119: host, Line 120: result, Line 121: ) Line 122: except: Oh... this is wrong in python, as you will also catch exceptions you do not mean to... at minimum it should be except Exception: Line 123: self.logger.debug( Line 124: "Cannot resolve kdump destination address '%s'", Line 125: host, Line 126: exc_info=True, -- To view, visit http://gerrit.ovirt.org/31760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5e83769ec9d6511d90f0e4f9b218338bb5d99a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
