Martin Peřina has posted comments on this change. Change subject: kdump: Try to resolve kdump destination host ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/31760/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 116: socket.getaddrinfo( Line 117: host, Line 118: None Line 119: ) Line 120: ]) > why not just print as debug the entire result of the command if you like to Done Line 121: self.logger.debug( Line 122: "Kdump destination '%s' addresses: '%s'", Line 123: host, Line 124: addresses Line 120: ]) Line 121: self.logger.debug( Line 122: "Kdump destination '%s' addresses: '%s'", Line 123: host, Line 124: addresses > comma Done Line 125: ) Line 126: resolvable = True Line 127: except socket.gaierror as e: Line 128: self.logger.debug( Line 127: except socket.gaierror as e: Line 128: self.logger.debug( Line 129: "Cannot resolve kdump destination '%s'", Line 130: host, Line 131: exc_info=True > comma Done Line 132: ) Line 133: return resolvable Line 134: Line 135: def _kexec_tools_version_supported(self): Line 221: self.environment[odeploycons.KdumpEnv.SUPPORTED] = ( Line 222: self._crashkernel_param_present() and Line 223: self._kexec_tools_version_supported() and Line 224: self._destination_address_resolvable( Line 225: self.environment[odeploycons.KdumpEnv.DESTINATION_ADDRESS] > I am unsure that this has anything with supported... it is somekind of erro OK, so you mean we should throw an error and fail deploy if kdump integration enabled, but destination address is not resolvable? About changing this in kdump: I doubt this it can be changed anytime soon, because they also treat remote crashdump targets in the same way: if NFS/SSH server is not resolvable during kdump initial ramdisk regeneration, they fail with an error, because they are unable to configure networking properly in kdump kernel. Line 226: ) Line 227: ) Line 228: Line 229: self.logger.info( -- To view, visit http://gerrit.ovirt.org/31760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5e83769ec9d6511d90f0e4f9b218338bb5d99a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
