Martin Peřina has posted comments on this change. Change subject: kdump: Try to resolve kdump destination host ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/31760/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 118: "Kdump destination '%s' addresses: '%s'", Line 119: host, Line 120: result, Line 121: ) Line 122: except socket.gaierror: > why not catch exception as generic? Done Line 123: self.logger.debug( Line 124: "Cannot resolve kdump destination address'%s'", Line 125: host, Line 126: exc_info=True, Line 126: exc_info=True, Line 127: ) Line 128: raise RuntimeError( Line 129: _("Cannot resolve kdump destination address '{host}'").format( Line 130: host=host > comma Done Line 131: ) Line 132: ) Line 133: Line 134: def _kexec_tools_version_supported(self): Line 246: stage=plugin.Stages.STAGE_MISC, Line 247: condition=lambda self: self.environment[odeploycons.KdumpEnv.ENABLE], Line 248: ) Line 249: def _misc(self): Line 250: # try to resolve kdump destination address before modifying kdump.conf > no need for a comment that equals to function name... Done Line 251: self._resolve_destination_address( Line 252: self.environment[odeploycons.KdumpEnv.DESTINATION_ADDRESS] Line 253: ) Line 254: Line 248: ) Line 249: def _misc(self): Line 250: # try to resolve kdump destination address before modifying kdump.conf Line 251: self._resolve_destination_address( Line 252: self.environment[odeploycons.KdumpEnv.DESTINATION_ADDRESS] > comma Done Line 253: ) Line 254: Line 255: with open(odeploycons.FileLocations.KDUMP_CONFIG_FILE, 'r') as f: Line 256: content = f.read().splitlines() Line 249: def _misc(self): Line 250: # try to resolve kdump destination address before modifying kdump.conf Line 251: self._resolve_destination_address( Line 252: self.environment[odeploycons.KdumpEnv.DESTINATION_ADDRESS] Line 253: ) > please move to validation Done Line 254: Line 255: with open(odeploycons.FileLocations.KDUMP_CONFIG_FILE, 'r') as f: Line 256: content = f.read().splitlines() Line 257: -- To view, visit http://gerrit.ovirt.org/31760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5e83769ec9d6511d90f0e4f9b218338bb5d99a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
