anmolbabu has posted comments on this change. Change subject: webadmin : Optimise for virt store on volumes ......................................................................
Patch Set 10: (5 comments) http://gerrit.ovirt.org/#/c/31041/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java: Line 416 Line 417 Line 418 Line 419 Line 420 > exclude this file from commit Done http://gerrit.ovirt.org/#/c/31041/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 429: allowRemove = false; Line 430: allowStartRebalance = false; Line 431: allowStopRebalance = false; Line 432: allowStatusRebalance = false; Line 433: allowOptimize = true; > 'Optimize for Virt' is enable even if no volumes are selected? Done Line 434: } Line 435: else { Line 436: List<GlusterVolumeEntity> list = Linq.<GlusterVolumeEntity> cast(getSelectedItems()); Line 437: allowStartProfiling = isStartProfileAvailable(list); Line 593: }else if(command.getName().equalsIgnoreCase("closeProfileStats")) {//$NON-NLS-1$ Line 594: setWindow(null); Line 595: } else if(command.getName().equalsIgnoreCase("doNotOptimiseForVirtStore")) {//$NON-NLS-1$ Line 596: cancel(); Line 597: } else if (command.getName().equalsIgnoreCase("continueOptimiseForVirtStore")) {//$NON-NLS-1$ > use CamelCase You meant for continueOptimiseForVirtStore ? But, its already in camel case Line 598: List<GlusterVolumeEntity> selectedVolumes = new ArrayList<GlusterVolumeEntity>(); Line 599: for(Object selectedVolume : getSelectedItems()) { Line 600: selectedVolumes.add((GlusterVolumeEntity) selectedVolume); Line 601: } Line 898: Line 899: private boolean isOptionEnabledOnVolume(GlusterVolumeEntity volume, GlusterVolumeOptionEntity checkOption) { Line 900: Collection<GlusterVolumeOptionEntity> volumeOptionsEnabled = volume.getOptions(); Line 901: for(GlusterVolumeOptionEntity option : volumeOptionsEnabled) { Line 902: if(option.getKey().equals(checkOption.getKey())) { > Don't we need to check the value as well? Done Line 903: return true; Line 904: } Line 905: } Line 906: return false; http://gerrit.ovirt.org/#/c/31041/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java: Line 158: localize(constants); Line 159: initAddBricksButton(); Line 160: initBricksCountLabele(); Line 161: driver.initialize(this); Line 162: virtStoreOptimiseWarningLabel.setText(constants.newVolumeOptimiseForVirtStoreWarning()); > this can be moved to localize() method Done Line 163: virtStoreOptimiseWarningLabel.setVisible(false); Line 164: } Line 165: Line 166: private void initCheckboxEditors() { -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
