anmolbabu has posted comments on this change. Change subject: webadmin : Optimise for virt store on volumes ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/31041/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 898: Line 899: private boolean isOptionEnabledOnVolume(GlusterVolumeEntity volume, GlusterVolumeOptionEntity checkOption) { Line 900: Collection<GlusterVolumeOptionEntity> volumeOptionsEnabled = volume.getOptions(); Line 901: for(GlusterVolumeOptionEntity option : volumeOptionsEnabled) { Line 902: if(option.getKey().equals(checkOption.getKey())) { > Done Currently, I am using this function to check if network.pingtimeout is set or not.If its set, vijay suggested that its not suggested to override the user set value. But,I'll try to make it a bit more generic so that it can take some evaluation condition parameter. Line 903: return true; Line 904: } Line 905: } Line 906: return false; -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
