anmolbabu has posted comments on this change. Change subject: webadmin : Optimise for virt store on volumes ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/31041/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java: Line 171: if(getOptimizeForVirtStore().getEntity()) { Line 172: if(getReplicaCount().getEntity() != 3) { Line 173: onPropertyChanged(new PropertyChangedEventArgs("volumeNotOfSuggestedConfigurationForVirtStoreOptimisation"));//$NON-NLS-1$ Line 174: } else { Line 175: onPropertyChanged(new PropertyChangedEventArgs("volumeOfSuggestedConfigurationForVirtStoreOptimisation"));//$NON-NLS-1$ > No need to use two different strings to notify events. Instead use a single Done Line 176: } Line 177: } else { Line 178: onPropertyChanged(new PropertyChangedEventArgs("noOptimiseForVirtStore"));//$NON-NLS-1$ Line 179: } -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
