Martin Peřina has posted comments on this change. Change subject: UI:Adding support for host with connectivity.. ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/31305/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1591: Line 1592: private void initHostsWithBrokenConnectivityThreshold() { Line 1593: ArrayList values = new ArrayList<Integer>(); Line 1594: // populating threshold values with {25, 50, 75, 100} Line 1595: for (int i=25; i<=100; i+=25) { Please add spaces before and after assignment and comparison operators Line 1596: values.add(i); Line 1597: } Line 1598: getHostsWithBrokenConnectivityThreshold().setItems(values); Line 1599: } http://gerrit.ovirt.org/#/c/31305/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 758: String.valueOf(object.getMemoryOverCommit())))); Line 759: } Line 760: } Line 761: Line 762: private void updateFencingPolicyTabVisibility(ClusterModel object) { This method is now useless since "Disable fencing" and "Skip fencing connectivity broken" are always visible, so whole tab is always visible. I plan to remove it completely, please take a look at http://gerrit.ovirt.org/31256 Line 763: fencingPolicyTab.setVisible( Line 764: object.getSkipFencingIfSDActiveEnabled().getIsChangable() || Line 765: object.getSkipFencingIfConnectivityBrokenEnabled().getIsChangable() Line 766: ); -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
