Martin Peřina has posted comments on this change. Change subject: UI: Adding support for host with connectivity.. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/31305/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1513: // Enabling setting this entity for all versions Line 1514: getSkipFencingIfConnectivityBrokenEnabled().setIsChangable(true); Line 1515: getHostsWithBrokenConnectivityThreshold().setIsChangable(true); Line 1516: getSkipFencingIfConnectivityBrokenEnabled().setEntity(getEntity() == null ? false : getEntity().getFencingPolicy().isSkipFencingIfConnectivityBroken()); Line 1517: getHostsWithBrokenConnectivityThreshold().setEntity(getEntity() == null ? 50 : getEntity().getFencingPolicy().getHostsWithBrokenConnectivityThreshold()); Please move this initialization before or after skipFencingIfSDActiveEnable and change the comment: private void updateFencingPolicyContent(Version ver) { // skipFencingIfConnectivityBroken is enabled for all cluster versions getSkipFencingIfConnectivityBrokenEnabled().setIsChangable(true); getHostsWithBrokenConnectivityThreshold().setIsChangable(true); getSkipFencingIfConnectivityBrokenEnabled().setEntity(getEntity() == null ? false : getEntity().getFencingPolicy().isSkipFencingIfConnectivityBroken()); getHostsWithBrokenConnectivityThreshold().setEntity(getEntity() == null ? 50 : getEntity().getFencingPolicy().getHostsWithBrokenConnectivityThreshold()); boolean supported = AsyncDataProvider.getInstance().isSkipFencingIfSDActiveSupported(ver.getValue()); ... Line 1518: if (supported) { Line 1519: if (getEntity() == null) { Line 1520: // this can happen when creating new cluster and cluster dialog is shown Line 1521: getSkipFencingIfSDActiveEnabled().setEntity(true); -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
