Eli Mesika has posted comments on this change. Change subject: UI:Adding support for host with connectivity.. ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/31305/13/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1509: Line 1510: private void updateFencingPolicyContent(Version ver) { Line 1511: boolean supported = AsyncDataProvider.getInstance().isSkipFencingIfSDActiveSupported(ver.getValue()); Line 1512: getSkipFencingIfSDActiveEnabled().setIsChangable(supported); Line 1513: // Enabling setting this entity for all versions > Please remove this comment Done Line 1514: if (supported) { Line 1515: if (getEntity() == null) { Line 1516: // this can happen when creating new cluster and cluster dialog is shown Line 1517: getSkipFencingIfSDActiveEnabled().setEntity(true); Line 1591: Line 1592: private void initHostsWithBrokenConnectivityThreshold() { Line 1593: ArrayList values = new ArrayList<Integer>(); Line 1594: // populating threshold values with {25, 50, 75, 100} Line 1595: for (int i=25; i<=100; i+=25) { > Please add spaces before and after assignment and comparison operators Done Line 1596: values.add(i); Line 1597: } Line 1598: getHostsWithBrokenConnectivityThreshold().setItems(values); Line 1599: } -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
