Oved Ourfali has posted comments on this change. Change subject: UI: Adding support for host with connectivity.. ......................................................................
Patch Set 7: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/31305/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1588: } Line 1589: Line 1590: private void initHostsWithBrokenConnectivityThreshold() { Line 1591: ArrayList values = new ArrayList<Integer>(); Line 1592: // populating threshold values with {0, 25, 50, 75, 100} remove the "0" from the comment. Line 1593: for (int i=25; i<=100; i+=25) { Line 1594: values.add(i); Line 1595: } Line 1596: getHostsWithBrokenConnectivityThreshold().setItems(values); http://gerrit.ovirt.org/#/c/31305/7/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3804: Line 3805: @DefaultStringValue("This will skip fencing for a Host that has live lease on Storage Domains") Line 3806: String skipFencingIfSDActiveInfo(); Line 3807: Line 3808: @DefaultStringValue("This will skip fence request on a Hots if its Cluster has more than the given threshold percents Hosts having connectivity issues") Change to: This will skip fencing if the percentage of Cluster Hosts with connectivity issues is greater than or equal to the defined threshold. Line 3809: String skipFencingWhenConnectivityBrokenInfo(); -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
