Ayal Baron has posted comments on this change.
Change subject: core: Change reconstruct flow
......................................................................
Patch Set 7: (1 inline comment)
Note that all the cleanups should be in a separate (one or more) patch (can be
same patch set), otherwise it makes reviewing your patch harder and it's more
likely for reviewer to miss important changes
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 256: protected void calcStoragePoolStatusByDomainsStatus() {
this change should be in a separate commit and is just making the review harder
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
