Yair Zaslavsky has posted comments on this change.
Change subject: core: Change reconstruct flow
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1280_add_last_time_used_as_master_col.sql
Line 1: select fn_db_add_column('storage_domain_static',
'last_time_used_as_master', 'BIGINT');
Don't you prefer to hold this as timestamp?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 258:
getNewMaster().getStorageStaticData().setLastTimeUsedAsMaster(System.currentTimeMillis());
See previous question about long vs Timestamp
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 227: context.snapshotEntityStatus(map, map.getstatus());
Shouldn't this be before the update status at db?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 293: context.snapshotEntity(getStoragePool());
Should't this be before getStoragePoolDao().update(getStoragePool())?
In addition, what change do you perform here that you do this update? I think
this part of code is a bit confusing.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
Line 244: _storageDomainSharedStatus = value;
Why are the next line removed? Just cleanup?
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
