Michael Kublin has posted comments on this change.
Change subject: core: Change reconstruct flow
......................................................................
Patch Set 7: (6 inline comments)
One relevant remark
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 285: _update_date = LOCALTIMESTAMP
Yes, after 5 rebases, I screw up a working code
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1280_add_last_time_used_as_master_col.sql
Line 1: select fn_db_add_column('storage_domain_static',
'last_time_used_as_master', 'BIGINT');
default value is NULL, I don't care about it. rs.getLon(null) = 0.
Comparator will sort at storages, I will choose a first one that is Active or
Uknown, if it will be origin it will still works
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 70: protected void setActionMessageParameters() {
No, In java we have marker @Override it is showing that I am overriding some
method at child class, when it use u can see at CommandBase - parent command
and why it uses
Line 168: // reset cache and mark reconstruct for pool as finished
Why what? there are no change except line format.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 288: Collections.sort(storageDomains, new
LastTimeUsedAsMasterComp());
Why, I can retrieve a domains by any order during a code, and I can choose to
sort domains by needed order during a code
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 256: protected void calcStoragePoolStatusByDomainsStatus() {
Yes I know, but I will not rebase a patch, I already did rebase 5 times
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
