Martin Mucha has posted comments on this change.

Change subject: core: coverity issue fix.
......................................................................


Patch Set 1:

about CID 1230092: 

there was code:

final Range rangeWithAvailableMac = getRangeWithAvailableMac();             
final List<Long> allocatedMacs = 
rangeWithAvailableMac.allocateMacs(remainingMacs);

and we've changed it (with moti) to:

getRangeWithAvailableMac().allocateMacs(remainingMacs);

in 

http://gerrit.ovirt.org/#/c/29155

——
moral: variable inlining does not work for convincing coverity.

I'll fix it, although it's not possible that method returns null.

-- 
To view, visit http://gerrit.ovirt.org/31067
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to