[Engine-patches] Change in ovirt-engine[master]: core: coverity issue fix.

[mmucha]

Martin Mucha has uploaded a new change for review.

Change subject: core: coverity issue fix.
......................................................................

core: coverity issue fix.

Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902
Signed-off-by: Martin Mucha <mmu...@redhat.com>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
1 file changed, 4 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/31067/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
index 817d7c6..a6241ca 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
@@ -13,7 +13,6 @@
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ErrorCollector;
 import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
@@ -36,9 +35,6 @@
 public class MacPoolPerDcTest {
     @Rule
     public ExpectedException expectedException = ExpectedException.none();
-
-    @Rule
-    public ErrorCollector errorCollector = new ErrorCollector();
 
     @Mock
     private DbFacade dbFacade;
@@ -270,24 +266,24 @@
     @Test
     public void testPoolForDataCenterMethod() throws Exception {
         expectNotInitializedException();
-        new MacPoolPerDc().poolForDataCenter(null);
+        new MacPoolPerDc().poolForDataCenter(Guid.newGuid());
     }
 
     @Test
     public void testCreatePoolMethod() throws Exception {
         expectNotInitializedException();
-        new MacPoolPerDc().createPool(null);
+        new MacPoolPerDc().createPool(new MacPool());
     }
 
     @Test
     public void testModifyPoolMethod() throws Exception {
         expectNotInitializedException();
-        new MacPoolPerDc().modifyPool(null);
+        new MacPoolPerDc().modifyPool(new MacPool());
     }
 
     @Test
     public void testRemovePoolMethod() throws Exception {
         expectNotInitializedException();
-        new MacPoolPerDc().removePool(null);
+        new MacPoolPerDc().removePool(Guid.newGuid());
     }
 }


-- 
To view, visit http://gerrit.ovirt.org/31067
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches