Lior Vernia has posted comments on this change. Change subject: core: coverity issue fix. ......................................................................
Patch Set 1: (2 comments) There was another Coverity defect on MacsStorage.java, CID 1230092. http://gerrit.ovirt.org/#/c/31067/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java: Line 271: Line 272: @Test Line 273: public void testCreatePoolMethod() throws Exception { Line 274: expectNotInitializedException(); Line 275: new MacPoolPerDc().createPool(new MacPool()); I don't think this was an issue with Coverity. Line 276: } Line 277: Line 278: @Test Line 279: public void testModifyPoolMethod() throws Exception { Line 283: Line 284: @Test Line 285: public void testRemovePoolMethod() throws Exception { Line 286: expectNotInitializedException(); Line 287: new MacPoolPerDc().removePool(Guid.newGuid()); I don't think this was an issue with Coverity. Line 288: } -- To view, visit http://gerrit.ovirt.org/31067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
