Maor Lipchuk has uploaded a new change for review.
Change subject: core: Set images with Storage Pool for images already on target.
......................................................................
core: Set images with Storage Pool for images already on target.
Setting images with storage pool id only for images which are already on
the Storage Domain, since importing a VM from configuration through the REST
does not oblegate an initialized Storage Domain
Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/30827/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
index 74c0030..b5f5c81 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
@@ -51,10 +51,12 @@
@Override
protected boolean canDoAction() {
- if (isImagesAlreadyOnTarget() &&
!validateUnregisteredEntity(vmFromConfiguration, ovfEntityData)) {
- return false;
+ if (isImagesAlreadyOnTarget()) {
+ if (!validateUnregisteredEntity(vmFromConfiguration,
ovfEntityData)) {
+ return false;
+ }
+ setImagesWithStoragePoolId(getStorageDomain().getStoragePoolId(),
getVm().getImages());
}
- setImagesWithStoragePoolId(getStorageDomain().getStoragePoolId(),
getVm().getImages());
return super.canDoAction();
}
--
To view, visit http://gerrit.ovirt.org/30827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
