Maor Lipchuk has posted comments on this change. Change subject: core: Set images with Storage Pool for images already on target. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30827/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 54: if (isImagesAlreadyOnTarget()) { Line 55: if (!validateUnregisteredEntity(vmFromConfiguration, ovfEntityData)) { Line 56: return false; Line 57: } Line 58: setImagesWithStoragePoolId(getStorageDomain().getStoragePoolId(), getVm().getImages()); > argg... since we are counting on the CDA logic. This all design should be re-visited after we will handle the RFE of re-design of the import processes Line 59: } Line 60: return super.canDoAction(); Line 61: } Line 62: -- To view, visit http://gerrit.ovirt.org/30827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
