Tomas Jelinek has uploaded a new change for review. Change subject: userportal,webadmin: Alignment issues in run once dialog ......................................................................
userportal,webadmin: Alignment issues in run once dialog 2 issues: - cloud init / network: in FR locale did not fit in. Fixed by making the dialog big enough that everything fits in - display / SPICE copy paste and SPICE file trenasfer label did not fit in. Fixed by making the checkboxes' labels bigger (same approach as on new / edit VM dialog) Change-Id: I37cf4c8909301ac3da6d414d0021af68d221f994 Bug-Url: https://bugzilla.redhat.com/1123749 Bug-Url: https://bugzilla.redhat.com/1123237 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java 4 files changed, 21 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/30826/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java index cba67aa..87d31f2 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java @@ -382,7 +382,7 @@ void initBootSequenceBox() { bootSequenceBox = new ListBox(false); - bootSequenceBox.setWidth("370px"); //$NON-NLS-1$ + bootSequenceBox.setWidth("475px"); //$NON-NLS-1$ bootSequenceBox.setHeight("60px"); //$NON-NLS-1$ VerticalPanel boxPanel = new VerticalPanel(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml index d92cca6..4952bdc 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml @@ -83,7 +83,7 @@ font-size: 10px; font-weight: bold; text-align: center; - width: 45px; + width: 65px; position: relative; left: 5px; } @@ -145,6 +145,21 @@ .cloudInitLabel { font-weight: bold; + } + + .checkboxWithLongLabel { + width: 400px; + float: left; + clear: both; + } + + .checkboxWithLongLabel label { + margin-left: 26px; + margin-top: -18px; + display: block; + line-height: 20px; + width: 400px; + float: left; } </ui:style> @@ -229,8 +244,8 @@ <ge:EntityModelRadioButtonEditor ui:field="displayConsoleVncEditor" /> <e:ListModelListBoxEditor ui:field="vncKeyboardLayoutEditor" /> <ge:EntityModelRadioButtonEditor ui:field="displayConsoleSpiceEditor" /> - <ge:EntityModelCheckBoxEditor ui:field="spiceFileTransferEnabledEditor" /> - <ge:EntityModelCheckBoxEditor ui:field="spiceCopyPasteEnabledEditor" /> + <ge:EntityModelCheckBoxEditor ui:field="spiceFileTransferEnabledEditor" addStyleNames="{style.checkboxWithLongLabel}" /> + <ge:EntityModelCheckBoxEditor ui:field="spiceCopyPasteEnabledEditor" addStyleNames="{style.checkboxWithLongLabel}" /> </g:VerticalPanel> </g:DisclosurePanel> diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java index 4507176..caab7e6 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java @@ -24,7 +24,7 @@ ApplicationResources resources, ApplicationConstants constants, ApplicationMessages messages) { - super(eventBus, resources, new VmRunOncePopupWidget(constants, resources, messages), "490px", "540px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmRunOncePopupWidget(constants, resources, messages), "610px", "540px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java index 8904abc..cf89f04 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java @@ -21,7 +21,7 @@ @Inject public VmRunOncePopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants, ApplicationMessages messages) { - super(eventBus, resources, new VmRunOncePopupWidget(constants, resources, messages), "490px", "540px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmRunOncePopupWidget(constants, resources, messages), "610px", "540px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); } -- To view, visit http://gerrit.ovirt.org/30826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37cf4c8909301ac3da6d414d0021af68d221f994 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
