Alon Bar-Lev has posted comments on this change. Change subject: packaging: Move JBoss modules from Makefile to spec ......................................................................
Patch Set 2: (1 inline comment) Thanks! Just a note about postgres jdbc... Tell me what you think... Alon .................................................... File Makefile Line 311 I am curios why you leave the postgres jdbc. Won't it work if the driver will be at the ear/lib? Please keep in mind the the symbolic link is fedora/redhat specific... I think that the build should place the real jar gotten from maven, and spec should replace with symlink link any other jar out there. This is not so important right now, but if we are to port this, it will be easier to have a complete make install output. Thanks! -- To view, visit http://gerrit.ovirt.org/6060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d4dd6d29c4db8486764d242d9c89ee8ecc0cba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
