Tomas Jelinek has posted comments on this change. Change subject: webadmin: Add option to skip fencing of host if SD is active ......................................................................
Patch Set 2: Code-Review+2 (1 comment) just a very small comment - please fix on rebase http://gerrit.ovirt.org/#/c/30195/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 720: String.valueOf(object.getMemoryOverCommit())))); Line 721: } Line 722: } Line 723: Line 724: private void updatefencingPolicyTabVisibility(ClusterModel object) { updateFencing (camel case) Line 725: fencingPolicyTab.setVisible( Line 726: object.getSkipFencingIfSDActiveEnabled().getIsChangable() Line 727: ); Line 728: } -- To view, visit http://gerrit.ovirt.org/30195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
