Oved Ourfali has posted comments on this change. Change subject: webadmin: Add option to skip fencing of host if SD is active ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 1868: Line 1869: @DefaultStringValue("Required Random Number Generator sources:") Line 1870: String requiredRngSources(); Line 1871: Line 1872: @DefaultStringValue("Skip fencing of a host with active SD:") Actually, according to the RFE opened on that, the label should be: "Disrupt fence request if target host is properly communicating with storage" Default should be ENABLED Line 1873: String skipFencingIfSDActive(); http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1482: getSkipFencingIfSDActiveEnabled().setIsChangable(supported); Line 1483: if (supported) { Line 1484: getSkipFencingIfSDActiveEnabled().setEntity(getEntity().isSkipFencingIfSDActive()); Line 1485: } else { Line 1486: getSkipFencingIfSDActiveEnabled().setEntity(false); Shouldn't it be setEnabled(false) ? or something similar? Line 1487: } Line 1488: } Line 1489: Line 1490: private void populateCPUList(ClusterModel clusterModel, List<ServerCpu> cpus, boolean canChangeArchitecture) http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3749: Line 3750: @DefaultStringValue("Save As Pdf") Line 3751: String exportToPdf(); Line 3752: Line 3753: @DefaultStringValue("This will skip fencing operations on a Host that has active Storage Domains") So "This will disrupt fence request on a Host that has active Storage Domains" Line 3754: String skipFencingIfSDActiveInfo(); http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 689: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 690: if (object.getVersion().getSelectedItem() != null) { Line 691: String clusterVersion = object.getVersion().getSelectedItem().getValue(); Line 692: fenceSettingsTab.setVisible( Line 693: AsyncDataProvider.getInstance().isSkipFencingIfSDActiveSupported(clusterVersion) That's indeed the logic for now. In the future we might need to check if there is any entry that is enabled. Line 694: ); Line 695: } Line 696: } Line 697: }); -- To view, visit http://gerrit.ovirt.org/30195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
