Martin Peřina has posted comments on this change. Change subject: webadmin: Add option to skip fencing of host if SD is active ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1482: getSkipFencingIfSDActiveEnabled().setIsChangable(supported); Line 1483: if (supported) { Line 1484: getSkipFencingIfSDActiveEnabled().setEntity(getEntity().isSkipFencingIfSDActive()); Line 1485: } else { Line 1486: getSkipFencingIfSDActiveEnabled().setEntity(false); > Looking at the code more, the logic is that you always show it, but set/uns Well, I hide the whole Fence settings tab based on cluster level, so the value cannot be changed when tab is not visible. Also when cluster level < 3.5, the value should be false (that's main reason for the logic here). About the default value: I copied default false from original Eli's patch and I didn't notice that it differs from RFE :-( I will change it to true by default for cluster level >= 3.5 Line 1487: } Line 1488: } Line 1489: Line 1490: private void populateCPUList(ClusterModel clusterModel, List<ServerCpu> cpus, boolean canChangeArchitecture) http://gerrit.ovirt.org/#/c/30195/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 689: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 690: if (object.getVersion().getSelectedItem() != null) { Line 691: String clusterVersion = object.getVersion().getSelectedItem().getValue(); Line 692: fenceSettingsTab.setVisible( Line 693: AsyncDataProvider.getInstance().isSkipFencingIfSDActiveSupported(clusterVersion) > That's indeed the logic for now. Well, I thought we can change the logic when we will have more than 1 option, but you are right. I will change it now to what you suggest. Line 694: ); Line 695: } Line 696: } Line 697: }); -- To view, visit http://gerrit.ovirt.org/30195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
