Mike Kolesnik has posted comments on this change. Change subject: core: filter the vds by query ......................................................................
Patch Set 2: (4 inline comments) .................................................... File backend/manager/dbscripts/vds_sp.sql Line 713: Create or replace FUNCTION GetVdsToRun(v_vds_type INTEGER, v_vds_groupid UUID, v_vds_status INTEGER, v_vds_minnrcpus INTEGER) RETURNS SETOF vds Why add new procedure and not change old one which will not be used anymore? Also I think v_vds_minnrcpus is not clean name, since it lacks separator between words. I would use instead something like: v_min_cpu_cores Line 719: WHERE Please remove TWS or even remove the \n since it looks like next line was cut off from this line accidentally. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java Line 292 This check doesn't appear in the query, so I guess either you didn't mean to remove it or forgot to add it to the query. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java Line 93: List<VDS> getVdsToRun(VDSType type, Guid groupId, VDSStatus status, int minNrOfCpus); Why add new methods and not change old ones which will not be used anymore? -- To view, visit http://gerrit.ovirt.org/5848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia899a81c46f7c0b3fc1e6addecaeb874d356df00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
