Omer Frenkel has posted comments on this change. Change subject: core: reset migration progress on migration end ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29763/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1998: Line 1999: _vmDict.put(vmToUpdate.argvalue.getId(), vmToUpdate.argvalue); Line 2000: if (vmNewDynamicData.getStatus() == VMStatus.Up) { Line 2001: vmToUpdate.argvalue.setMigrationProgressPercent(0); Line 2002: addVmStatisticsToList(vmToUpdate.argvalue.getStatisticsData()); > no, here the problem is that the VmStatistics are updated only if _vdsManag in that case i perfer not to fix it now, its not a nice exception in the code, and we might be able to do it nicely in the new monitoring code. also, this code will not always be executed in migration end flow, if we dont miss the hand-over (most cases). currently this value is statistics value, which is updated every statistics cycle. you have the same scenario if migration ended just after the statistics cycle.. Line 2003: if (!_succededToRunVms.contains(vmToUpdate.argvalue.getId())) { Line 2004: _succededToRunVms.add(vmToUpdate.argvalue.getId()); Line 2005: } Line 2006: } -- To view, visit http://gerrit.ovirt.org/29763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeb3875da032622d53f3921b0186b08009e4a191 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
