Tomas Jelinek has posted comments on this change. Change subject: core: reset migration progress on migration end ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29763/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1932: && currentVmStatus.isRunning()) { Line 1933: _vmsToRerun.add(runningVm.getId()); Line 1934: log.infoFormat("Adding VM {0} to re-run list", runningVm.getId()); Line 1935: vmToUpdate.setMigratingToVds(null); Line 1936: vmToUpdate.setMigrationProgressPercent(0); > i dont understand why this is needed, if this is source host, and new statu VDSM reports the last value so the client will know where did it die. But since we are using it only to show the current status during migration, we need to null it here. Line 1937: addVmStatisticsToList(vmToUpdate.getStatisticsData()); Line 1938: } Line 1939: } Line 1940: -- To view, visit http://gerrit.ovirt.org/29763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeb3875da032622d53f3921b0186b08009e4a191 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
