Omer Frenkel has posted comments on this change. Change subject: core: reset migration progress on migration end ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29763/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1998: Line 1999: _vmDict.put(vmToUpdate.argvalue.getId(), vmToUpdate.argvalue); Line 2000: if (vmNewDynamicData.getStatus() == VMStatus.Up) { Line 2001: vmToUpdate.argvalue.setMigrationProgressPercent(0); Line 2002: addVmStatisticsToList(vmToUpdate.argvalue.getStatisticsData()); and why here? it is reported also on destination when migration succeeded? i dont like these special cases in code if its not necessary Line 2003: if (!_succededToRunVms.contains(vmToUpdate.argvalue.getId())) { Line 2004: _succededToRunVms.add(vmToUpdate.argvalue.getId()); Line 2005: } Line 2006: } -- To view, visit http://gerrit.ovirt.org/29763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeb3875da032622d53f3921b0186b08009e4a191 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
