Liron Aravot has posted comments on this change. Change subject: core: Allow attach of Storage Domain when retrieve fails ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/29563/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 190: } Line 191: Line 192: protected List<OvfEntityData> getEntitiesFromStorageOvfDisk() { Line 193: List<OvfEntityData> ovfEntitiesFromTar = Collections.emptyList(); Line 194: boolean isUnregisteredDisksRetrieved = false; /s/isUnregisteredDisksRetrieved/isOvfDataRetrieved Line 195: // Get all unregistered disks. Line 196: List<Disk> unregisteredDisks = getBackend().runInternalQuery(VdcQueryType.GetUnregisteredDisks, Line 197: new GetUnregisteredDisksQueryParameters(getParameters().getStorageDomainId(), Line 198: getVds().getStoragePoolId())).getReturnValue(); Line 215: OvfUtils.getOvfEntities((byte[]) retrievedByteData.getReturnValue(), Line 216: getParameters().getStorageDomainId()); Line 217: isUnregisteredDisksRetrieved = true; Line 218: } Line 219: } catch (VdcBLLException e) { this should be either separated or runtime exception Line 220: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}", Line 221: ovfDisk.getId(), Line 222: getParameters().getStorageDomainId()); Line 223: } http://gerrit.ovirt.org/#/c/29563/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 634: VDS_HIGH_CPU_USE=Used CPU of host ${HostName} [${UsedCpu}%] exceeded defined threshold [${Threshold}%]. Line 635: VDS_HIGH_SWAP_USE=Used swap memory of host ${HostName} [${UsedSwap}%] exceeded defined threshold [${Threshold}%]. Line 636: VDS_LOW_SWAP=Available swap memory of host ${HostName} [${AvailableSwapMemory} MB] is under defined threshold [${Threshold} MB]. Line 637: UPDATE_OVF_FOR_STORAGE_POOL_FAILED=Failed to update VMs/Templates OVF data in Data Center ${StoragePoolName}. Line 638: RETRIEVE_OVF_STORE_FAILED=Failed to retrieve VMs and Templates from the ovf store disk at Storage Domain ${StorageDomainName}. /s/ovf/OVF /s/at/of Line 639: UPDATE_OVF_FOR_STORAGE_DOMAIN_FAILED=Failed to update VMs/Templates OVF data for Storage Domain ${StorageDomainName} in Data Center ${StoragePoolName}. Line 640: CREATE_OVF_STORE_FOR_STORAGE_DOMAIN_FAILED=Failed to create OVF store disk for Storage Domain ${StorageDomainName}.\n The Disk with the alias ${DiskAlias} might be removed manually for automatic attempt to create new one. \n OVF updates won't be attempted on the created disk. Line 641: CREATE_OVF_STORE_FOR_STORAGE_DOMAIN_INITIATE_FAILED=Failed to create OVF store disk for Storage Domain ${StorageDomainName}. \n OVF data won't be updated meanwhile for that domain. Line 642: UPDATE_DESCRIPTION_FOR_OVF_STORE_FAILED=Failed to update OVF disk ${DiskId} description to reflect its state, OVF data isn't updated on that OVF store (Data Center ${DataCenterName}, Storage Domain ${StorageDomainName}). -- To view, visit http://gerrit.ovirt.org/29563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b8c572898a07f5d706e2b58c94ce101da6df5ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
