Liron Aravot has posted comments on this change. Change subject: core: Allow attach of Storage Domain when OVF STORE fails ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29563/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 214: OvfUtils.getOvfEntities((byte[]) retrievedByteData.getReturnValue(), Line 215: getParameters().getStorageDomainId()); Line 216: } Line 217: } catch (VdcBLLException e) { Line 218: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}", 1. /s/Image/Ovf store 2. Let's have this as an audit log, so the user will know that he won't be able to import his vms/templates. 3. This audit log should be displayed also when ovf disk isn't found so let's do it like - boolean succeeded = false... - try to get disk/data...if succesfull succeeded = true - if (!succeeded) ... audit log Line 219: ovfDisk.getId(), Line 220: getParameters().getStorageDomainId()); Line 221: } Line 222: } -- To view, visit http://gerrit.ovirt.org/29563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b8c572898a07f5d706e2b58c94ce101da6df5ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
