Maor Lipchuk has posted comments on this change. Change subject: core: Allow attach of Storage Domain when OVF STORE fails ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29563/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 214: OvfUtils.getOvfEntities((byte[]) retrievedByteData.getReturnValue(), Line 215: getParameters().getStorageDomainId()); Line 216: } Line 217: } catch (VdcBLLException e) { Line 218: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}", > 1. /s/Image/Ovf store 1. we retrieve images not OVF store, so I prefer to leave it that way 2. done 3.The audit log should be displayed if we can't retrive OVF at all. this should be when the full solution will be merged (list of OVF disks). For now I added a boolean Line 219: ovfDisk.getId(), Line 220: getParameters().getStorageDomainId()); Line 221: } Line 222: } -- To view, visit http://gerrit.ovirt.org/29563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b8c572898a07f5d706e2b58c94ce101da6df5ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
