Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: binding file groups and product options ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/29206/8/packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py File packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py: Line 228: if product_option in self.environment[ Line 229: osetupcons.RemoveEnv.REMOVE_OPTIONS Line 230: ]: Line 231: if not optional: Line 232: add_group = True mmm.... What happens if product_option is None and optional is False? Line 233: elif ( Line 234: interactive and Line 235: group not in already_asked Line 236: ): -- To view, visit http://gerrit.ovirt.org/29206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad7cd9d8196da89e5c4800aa1263467853f136f8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
