Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: asking about CA stuff during engine partial cleanup ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29206/5/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py: Line 92: # be available there anyway... so we can modify names. Line 93: # also, if there is some kind of a problem we can have Line 94: # temporary mapping between old and new. Line 95: # anything that will require update of both setup and remove Line 96: # on regular basis. > we basically need to trace two distinct things: 1. we can add a product=... key 2. optional= key is meant for that purpose. But if you need more semantic we can add a shared=True/False key. About cleanup of previous release, those releases must be cleaned by their cleanup. We should ensure cleanup is able to clean current release. BTW, we can change this in a future patch, not in this one. Line 97: self.environment[ Line 98: osetupcons.RemoveEnv.REMOVE_SPEC_OPTION_GROUP_LIST Line 99: ].extend( Line 100: [ -- To view, visit http://gerrit.ovirt.org/29206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad7cd9d8196da89e5c4800aa1263467853f136f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
