Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: binding file groups and product options ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/29206/7/packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py File packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py: Line 114: if not config.has_section(section): Line 115: config.add_section(section) Line 116: config.set(section, 'description', description) Line 117: config.set(section, 'optional', optional) Line 118: config.set(section, 'product_o', product_o) > why product_o and not product_option? Done Line 119: Line 120: def _addFiles(section, files): Line 121: for index, name in enumerate(sorted(set(files))): Line 122: if os.path.exists(name): http://gerrit.ovirt.org/#/c/29206/7/packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py File packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py: Line 223: Line 224: add_group = self.environment[ Line 225: osetupcons.RemoveEnv.REMOVE_ALL Line 226: ] Line 227: if not add_group: > Note that legacy uninstall files will not have product_o so None may be che Done Line 228: if product_o in self.environment[ Line 229: osetupcons.RemoveEnv.REMOVE_OPTIONS Line 230: ]: Line 231: if not optional: -- To view, visit http://gerrit.ovirt.org/29206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad7cd9d8196da89e5c4800aa1263467853f136f8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
