Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(8 inline comments)
like the idea, see some comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 39:
The initial value is a constant - replace it with AuditLogType.UNASSIGNED;
Line 44: private static Object _doubleRegistrationLock = new Object();
performance: create this as BitSet('z'+1) to prevent resizing in the static
block.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterVdsQueryTest.java
Line 15: * A test for checking whether getStrippedVdsUniqueId method
returns a valid VDS id which contains only the valid
use {@link for the method references)
Line 23: assertEquals("Test_123", result);
Please add an assertion message to the asserEquals() call.
Line 27: * A test for checking whether getStrippedVdsUniqueId method
returns a valid VDS id when containing no invalid
@link here too.
Line 35: assertEquals("Test_123", result);
Please add an assertion message to the asserEquals() call.
Line 40: * A test for checking whether getStrippedVdsUniqueId method
returns an empty VDS id when containing only invalid
@link here too.
Line 48: assertEquals("", result);
Please add an assertion message to the asserEquals() call.
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
