Liron Aravot has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 40: private AuditLogType _error = AuditLogType.UNASSIGNED;
I agree with you, new patch will be submitted with this change.
Line 41: private String _strippedVdsUniqueId;
it's not a field that has been added by me, so i didn't change it in this
patch. will be changed in a different patch.
Line 47: // value.
will change
Line 50: static {
As we discussed , would be left like this.
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
