Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 44: private static Object _doubleRegistrationLock = new Object();
a lock object should be final - probably not as part of this patch.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterVdsQueryTest.java
Line 22: String result = getQuery().getStrippedVdsUniqueId();
You have these same three lines repeating themselves in all the tests.
consider extracting them to a method, like getStrippedVdsUniqueId(String)
Line 48: assertEquals("Vds id is not empty as expected", result, "");
The order of the arguments is reversed - it should be assertEquals("Vds id is
not empty as expected", "", result);
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
