Lior Vernia has posted comments on this change. Change subject: engine: Remove support for LinuxBridge plugin ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28790/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java: Line 25: } Line 26: Collections.sort(displayStrings, new LexoNumericComparator()); Line 27: } Line 28: Line 29: private static OpenstackNetworkPluginType[] getOpenstackNetworkPlugins() { > The LinuxBridge is being presented nicely (the enum is being translated to Yes, after further inspection I understand why it's displayed nicely. However, I still think that making sure Linux Bridge is removed (or isn't added) is better than adding Open vSwitch, the reason being that if another plugin is now added, you'll have to remember to maintain add it here as well rather than have it work out automatically. This removal may take place as part of the static initialization segment, so it'll only take place once. You can put the logic in a conditional clause, which will take place only when the plugin isn't Linux Bridge. Line 30: return new OpenstackNetworkPluginType[] { OpenstackNetworkPluginType.OPEN_VSWITCH }; Line 31: } Line 32: Line 33: public static List<String> getPresetDisplayStrings() { -- To view, visit http://gerrit.ovirt.org/28790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa05188a5cba9987754058b2492329a6134e52e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
