Moti Asayag has posted comments on this change. Change subject: engine: Remove support for LinuxBridge plugin ......................................................................
Patch Set 3: Verified+1 (2 comments) http://gerrit.ovirt.org/#/c/28790/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java: Line 23: * Line 24: * @return <code>false</code> the Linux Bridge plugin is deprecated and replaced by ml2. Line 25: */ Line 26: public final boolean isLinuxBridge() { Line 27: return false; > I don't think this is the right thing to change, as it's possible some prov I agree, a complete deprecation will be conducted in next version. For 3.5 we'd like to remove this possibility from the UI only. If no complains about it - we'll remove it from the VdsDeploy and later-on from the ovirt-host-deploy and from the vdsm-hook-openstacknet. Line 28: } Line 29: Line 30: /** Line 31: * Convenience method to know if the plugin represented is Open vSwitch. http://gerrit.ovirt.org/#/c/28790/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java: Line 25: } Line 26: Collections.sort(displayStrings, new LexoNumericComparator()); Line 27: } Line 28: Line 29: private static OpenstackNetworkPluginType[] getOpenstackNetworkPlugins() { > If you want the Linux Bridge to still be displayed prettily in case it's th The LinuxBridge is being presented nicely (the enum is being translated to its display value), but that value will not be available for users to select. IMO, initializing the displayStrings with the expected value is preferred than adding all the values and removing the unneeded one (it saves an action each time getPresetDisplayStrings() is being called). Line 30: return new OpenstackNetworkPluginType[] { OpenstackNetworkPluginType.OPEN_VSWITCH }; Line 31: } Line 32: Line 33: public static List<String> getPresetDisplayStrings() { -- To view, visit http://gerrit.ovirt.org/28790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa05188a5cba9987754058b2492329a6134e52e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
