Lior Vernia has posted comments on this change. Change subject: engine: Remove support for LinuxBridge plugin ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28790/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java: Line 23: * Line 24: * @return <code>false</code> the Linux Bridge plugin is deprecated and replaced by ml2. Line 25: */ Line 26: public final boolean isLinuxBridge() { Line 27: return false; I don't think this is the right thing to change, as it's possible some providers are still configured with Linux Bridge plugin, so the return value of isLinuxBridge() might surprise developers who use it. It's probably better to change the code that uses it in VdsDeploy, don't you agree? Line 28: } Line 29: Line 30: /** Line 31: * Convenience method to know if the plugin represented is Open vSwitch. http://gerrit.ovirt.org/#/c/28790/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java: Line 25: } Line 26: Collections.sort(displayStrings, new LexoNumericComparator()); Line 27: } Line 28: Line 29: private static OpenstackNetworkPluginType[] getOpenstackNetworkPlugins() { If you want the Linux Bridge to still be displayed prettily in case it's the configured plugin, then I think it needs to be part of the iteration that calls this method. To not have it as part of the suggestions in the dialog, instead of adding this method you can modify getPresetDisplayStrings() to return a copy of displayStrings with Linux Bridge removed. Line 30: return new OpenstackNetworkPluginType[] { OpenstackNetworkPluginType.OPEN_VSWITCH }; Line 31: } Line 32: Line 33: public static List<String> getPresetDisplayStrings() { -- To view, visit http://gerrit.ovirt.org/28790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa05188a5cba9987754058b2492329a6134e52e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
