Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix sync ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28561/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java: Line 159: } Line 160: } Line 161: Line 162: // Repeat the same for groups from db. Line 163: if (dbGroups.get(namespace) != null) { > this is somewhat strange... as the namespace loop should be inner loop and Ah, I didn't know that this is possible (i.e - group in namespace x member of namespace y). The first fetch I perform is of users - this also has to be per namespace. this was the motivation to the outer loop - the outer loop at refreshUsers takes the user ids per each namespace and fetches their groups. I understand per your comment I may miss here an internal loop as well. Line 164: List<DirectoryGroup> directoryGroups = new ArrayList<>(dbGroups.get(namespace).size()); Line 165: for (DbGroup dbGroup : dbGroups.get(namespace)) { Line 166: if (groupFromAuthzProvider(dbGroup, AuthzUtils.getName(authz))) { Line 167: directoryGroups.add( -- To view, visit http://gerrit.ovirt.org/28561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49b51517a967c7a83e8e73f52181673baa31700 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
