Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix sync ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/28561/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java: Line 169: } Line 170: } Line 171: } Line 172: Line 173: Map<String, DirectoryGroup> cache = new HashMap<>(); > user1 -> group1, group2 ok, if you look above you will see that i actually do fetch users first, the problem is that i did not prevent the groups from being fetched (1st level fetch) after the groups of the users were. Line 174: populateRecrusiveGroups(authz, cache, toFetch); Line 175: Line 176: Line 177: Line 170: } Line 171: } Line 172: Line 173: Map<String, DirectoryGroup> cache = new HashMap<>(); Line 174: populateRecrusiveGroups(authz, cache, toFetch); > no... your algorithm should not be recursive at all this is where you are c Where is my algorithm recursive besides of the "flattening"? Line 175: Line 176: Line 177: Line 178: for (DirectoryUser directoryUser : directoryUsers) { -- To view, visit http://gerrit.ovirt.org/28561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49b51517a967c7a83e8e73f52181673baa31700 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
