Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix sync ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/28561/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java: Line 224: for (DirectoryGroup group : toFetch.values()) { Line 225: cache.put(group.getId(), group); Line 226: } Line 227: } else { Line 228: for (DirectoryGroup group : toFetch.values()) { you must loop until nothing more to resolve. Line 229: if (!cache.containsKey(group.getId())) { Line 230: Set<DirectoryGroup> flatGroups = new HashSet<>(); Line 231: DirectoryGroup fetchedGroup = AuthzUtils.findGroupById(authz, group.getNamespace(), group.getId(), true); Line 232: cache.put(fetchedGroup.getId(), fetchedGroup); Line 227: } else { Line 228: for (DirectoryGroup group : toFetch.values()) { Line 229: if (!cache.containsKey(group.getId())) { Line 230: Set<DirectoryGroup> flatGroups = new HashSet<>(); Line 231: DirectoryGroup fetchedGroup = AuthzUtils.findGroupById(authz, group.getNamespace(), group.getId(), true); again, do not find by id, always prepare a list of unresolved entries Line 232: cache.put(fetchedGroup.getId(), fetchedGroup); Line 233: DirectoryUtils.flatGroups(flatGroups, fetchedGroup.getGroups()); Line 234: for (DirectoryGroup fetchedMemberOf : flatGroups) { Line 235: cache.put(fetchedMemberOf.getId(), fetchedMemberOf); http://gerrit.ovirt.org/#/c/28561/7/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java: Line 121 Line 122 Line 123 Line 124 Line 125 - -- To view, visit http://gerrit.ovirt.org/28561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49b51517a967c7a83e8e73f52181673baa31700 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
